Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix push_release_tag_* jobs in release CI #59

Merged
merged 2 commits into from
Nov 4, 2020
Merged

Conversation

clamoriniere
Copy link
Collaborator

@clamoriniere clamoriniere commented Nov 4, 2020

What does this PR do?

push_release_tag job didn't work as expected, the environment variable were not propagated to the extended job:

  • fix push_release_tag_controller job
  • create missing push_release_tag_check

Motivation

Fix releasing process

Additional Notes

Anything else we should know when reviewing?

Describe your test plan

Write there any instructions and details you may have to test your PR.

@clamoriniere clamoriniere requested a review from a team as a code owner November 4, 2020 12:05
@clamoriniere clamoriniere added the bug Something isn't working label Nov 4, 2020
@clamoriniere clamoriniere added this to the v0.4 milestone Nov 4, 2020
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request contains a valid label.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request contains a valid label.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request contains a valid label.

@ahmed-mez ahmed-mez merged commit 49e744e into v0.4 Nov 4, 2020
@ahmed-mez ahmed-mez deleted the clamoriniere/fix-ci branch November 4, 2020 12:16
ahmed-mez added a commit that referenced this pull request Nov 16, 2020
* release v0.4.0-rc.1

* Fix push_release_tag_* jobs in release CI (#59)

* Fix push_release_tag_* jobs in release CI

* add when: manual

* release v0.4.0-rc.2

* fix canary fail metric (#61)

* release v0.4.0-rc.3

* release v0.4.0

Co-authored-by: Cedric Lamoriniere <cedric.lamoriniere@datadoghq.com>
Co-authored-by: Celene <celene@datadoghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants