Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[e2e] Resurrecting e2e tests on kind with envtest framework #67

Merged
merged 3 commits into from
Dec 3, 2020

Conversation

xornivore
Copy link
Contributor

What does this PR do?

  • Added initial tests for testing autoPause and autoFail of canary on pod restarts.

Motivation

  • While envtest control plane tests are great they don't allow us to exercise scenarios that assert on behaviors involving failure cases such as pod restarts.

Additional Notes

Anything else we should know when reviewing?

Describe your test plan

Write there any instructions and details you may have to test your PR.

@xornivore xornivore added enhancement New feature or request component/controller labels Dec 2, 2020
@xornivore xornivore added this to the v0.4 milestone Dec 2, 2020
@xornivore xornivore requested a review from a team December 2, 2020 14:35
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request contains a valid label.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request contains a valid label.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request contains a valid label.

@xornivore xornivore force-pushed the xornivore/eds-e2e-tests-on-kind branch from 4431122 to fc77f2c Compare December 2, 2020 15:10
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request contains a valid label.

@xornivore xornivore force-pushed the xornivore/eds-e2e-tests-on-kind branch from fc77f2c to 9f10708 Compare December 2, 2020 15:18
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request contains a valid label.

…amework

- Added initial tests for testing autoPause and autoFail of canary on pod restarts.
@xornivore xornivore force-pushed the xornivore/eds-e2e-tests-on-kind branch from 9f10708 to f1e9300 Compare December 2, 2020 15:34
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request contains a valid label.

@xornivore xornivore modified the milestones: v0.4, v0.5 Dec 2, 2020
@xornivore xornivore changed the title [e2e] WIP Resurrecting e2e tests on kind but in the envtest framework [e2e] Resurrecting e2e tests on kind with envtest framework Dec 3, 2020
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request contains a valid label.

@xornivore xornivore marked this pull request as ready for review December 3, 2020 03:06
@codecov-io
Copy link

codecov-io commented Dec 3, 2020

Codecov Report

Merging #67 (3a16d9e) into master (2db920b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #67   +/-   ##
=======================================
  Coverage   31.39%   31.39%           
=======================================
  Files          37       37           
  Lines        2758     2758           
=======================================
  Hits          866      866           
  Misses       1809     1809           
  Partials       83       83           
Flag Coverage Δ
unittests 31.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
controllers/setup.go 77.77% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2db920b...3a16d9e. Read the comment docs.

Copy link
Collaborator

@clamoriniere clamoriniere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work @xornivore 🥇

Co-authored-by: Cedric Lamoriniere <cedric.lamoriniere@datadoghq.com>
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request contains a valid label.

@xornivore xornivore merged commit c125046 into master Dec 3, 2020
@xornivore xornivore deleted the xornivore/eds-e2e-tests-on-kind branch December 3, 2020 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants