[eds] Introduce PodCannotStart condition and canary auto-pause handling #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
xornivore
force-pushed
the
xornivore/eds-canary-handle-waiting-state-failures
branch
from
a72d934
to
ae09707
Compare
Codecov Report
@@ Coverage Diff @@
## master #68 +/- ##
==========================================
+ Coverage 31.39% 31.68% +0.28%
==========================================
Files 37 37
Lines 2758 2818 +60
==========================================
+ Hits 866 893 +27
- Misses 1809 1839 +30
- Partials 83 86 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
- Introduces logic to handle certain failure waiting states as cause for auto-pausing canary. - Simplifies logic for reported container states in terminated reason (will basically take anything). - e2e tests for PodCannotStart scenarios (container config error and image pull errors).
xornivore
force-pushed
the
xornivore/eds-canary-handle-waiting-state-failures
branch
from
ae09707
to
466aaa9
Compare
clamoriniere
reviewed
Dec 4, 2020
clamoriniere
reviewed
Dec 4, 2020
clamoriniere
reviewed
Dec 6, 2020
clamoriniere
approved these changes
Dec 7, 2020
- Improve logging - Colorize e2e test milestone logs - Add error logs around reconciler scenarios on update, still require more investigation.
xornivore
force-pushed
the
xornivore/eds-canary-handle-waiting-state-failures
branch
from
635da0e
to
3405370
Compare
xornivore
deleted the
xornivore/eds-canary-handle-waiting-state-failures
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
PodCannotStartconditions/scenarios (container config error and image pull errors).Motivation
Current limitations in support for container waiting state which are abnormal and should result in pausing canary.
Additional Notes
Anything else we should know when reviewing?
Describe your test plan
Scenarios similar to tests in e2e.