make the depth of the io rings a configurable knob #463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryandmc
approved these changes
Nov 17, 2021
| @@ -1164,6 +1165,7 @@ impl Reactor { | |||
| pub(crate) fn new( | |||
| notifier: Arc<sys::SleepNotifier>, | |||
| mut io_memory: usize, | |||
| ring_depth: usize, | |||
| ) -> io::Result<Reactor> { | |||
| const MIN_MEMLOCK_LIMIT: u64 = 512 * 1024; | |||
There was a problem hiding this comment.
If you are changing the size of the rings does this need to be adjusted in any way? I don't know for a fact it does but it seems like it will require more memory.. Obviously this amount may still be enough but I think it's worth looking into.
There was a problem hiding this comment.
The actual memlock limit is a bit unpredictable. It depends on the number of executors, amount of I/O memory, and etc. The message is supposed to indicate a "good default".
|
@HippoBaro there is a test failing after updating the branch |
Previously our io rings had a depth of 128. This patch makes the reactor take a ring depth argument upon creation to size the rings.
Default remains 128.
HippoBaro
force-pushed
the
variable_ring_depth
branch
from
c74609b
to
8345503
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously our io rings had a depth of 128. A user can now override this
if they feel like it. If they do, the setting will be used as the concurrency
level of
reqad_manyas well.