fix test for file send #627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test is broken because we can't really guarantee that the old fd will fail to open. It is entirely possible that by now, some other test (remember tests are threaded) have opened a new file for itself that ended up with the same fd as original_fd. This test was always failing for me when I ran "cargo test" but always succeeding if I ran the test in isolation, which confirms that this is the likely cause.
|
@vlovich FYI |
|
Uggh. Terrible oversight on my part. I’m usually good about stuff like
that. Thanks for tracking it down and will be more mindful going forward.
…On Thu, Nov 23, 2023 at 6:32 AM Glauber Costa ***@***.***> wrote:
Merged #627 <#627> into master.
—
Reply to this email directly, view it on GitHub
<#627 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABRERZOW7EMOOR7JNQPNH3YF5NAFAVCNFSM6AAAAAA7X3Q462VHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJRGA2DQNBRGE3DKNA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test is broken because we can't really guarantee that the old fd will fail to open. It is entirely possible that by now, some other test (remember tests are threaded) have opened a new file for itself that ended up with the same fd as original_fd.
This test was always failing for me when I ran "cargo test" but always succeeding if I ran the test in isolation, which confirms that this is the likely cause.