[AIT-8952] Generate DD_INSTRUMENTATION_INSTALL_TIME and DD_INSTRUMENTATION_INSTALL_ID #1263
Conversation
…RUMENTATION_INSTALL_ID
liliyadd
changed the title
| {{ include "datadog.labels" . | indent 4 }} | ||
| data: | ||
| install_id: {{ uuidv4 | quote }} | ||
| install_type: unknown |
There was a problem hiding this comment.
is this desired? (from the doc, why is it not k8s_single_step ?)
There was a problem hiding this comment.
Corrected. The default value should be k8s_manual, the same as in Operator.
| apiVersion: v1 | ||
| kind: ConfigMap | ||
| metadata: | ||
| name: kpi-telemetry-configmap |
There was a problem hiding this comment.
I'm not sure if it is good to have a fix name here. because we have some use case (like windows install that require to deploy/install twice this chart in the same namespace)
Also can we create this configmap only if APM SSI is enabled?
There was a problem hiding this comment.
- Parametrized the Configmap name with
.Release.name - We need this env variables to get KPIs for all of manual instrumentation, local library injection and SSI. Thus we cannot condition configmap on SSI enablement.
There was a problem hiding this comment.
Ok but maybe at least when the admission controller is enabled
There was a problem hiding this comment.
Sorry, I was too quick merging this. This is not in parity with the Operator, which adds these envs only if APM feature is enabled. If we add AC check here, we should update Operator code, otherwise we add APM check here.
There was a problem hiding this comment.
This is not in parity with the Operator, which adds these envs only if APM feature is enabled
This is the Operator code that sets these env variables. I believe we always set these env variables and not only when APM is enabled.
There was a problem hiding this comment.
I was referring to trace agent, which is not run when APM is disabled so behavior should match. Sorry for confusion.
| @@ -151,3 +151,13 @@ Return a list of env-vars if the cluster-agent is enabled | |||
| key: token | |||
| {{- end }} | |||
| {{- end -}} | |||
|
|
|||
|
|
|||
| {{- define "kpi-envvar" -}} | |||
There was a problem hiding this comment.
Isn't this redundant since env vars are inlined in both trace agent and DCA containers?
There was a problem hiding this comment.
Thanks for catching it. This code re-appeared after merge from remote branch.
Generates DD_INSTRUMENTATION_INSTALL_TIME and DD_INSTRUMENTATION_INSTALL_ID on installation of Cluster Agent. These env variables are used to power APM time-to-value KPI
https://datadoghq.atlassian.net/browse/AIT-8952
Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
.github/helm-docs.sh)CHANGELOG.mdhas been updatedREADME.mdmake update-test-baselines)