Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding DD_DOGSTATSD_TAG_CARDINALITY capability #22

Merged
merged 2 commits into from
Aug 14, 2020
Merged

Adding DD_DOGSTATSD_TAG_CARDINALITY capability #22

merged 2 commits into from
Aug 14, 2020

Conversation

anthony-pastor
Copy link
Contributor

@anthony-pastor anthony-pastor commented Aug 13, 2020

To add this missing field: #21

@anthony-pastor anthony-pastor requested a review from a team as a code owner August 13, 2020 15:20
@vboulineau
Copy link
Contributor

Hey @anthony-pastor,

Thanks for your contribution.
To validate your PR, please:

  • Document the new parameter in README.md
  • Bump Chart version
  • Use a more descriptive commit message (that can be used as a changelog)

@anthony-pastor anthony-pastor changed the title add-tag-cardinality Adding DD_DOGSTATSD_TAG_CARDINALITY capability Aug 13, 2020
@anthony-pastor
Copy link
Contributor Author

Hey @anthony-pastor,

Thanks for your contribution.
To validate your PR, please:

* Document the new parameter in `README.md`

* Bump Chart version

* Use a more descriptive commit message (that can be used as a changelog)

I've added a commit to address your comments.

@vboulineau vboulineau merged commit bf48a11 into DataDog:master Aug 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants