move kube-state-metrics sub-chart from google registry to charts.helm.sh #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you please also update the |
|
You should also update references in |
faarshad
force-pushed
the
fix/mv-ksm-subchart-to-new-helm-registry
branch
from
c323e0b
to
080c618
Compare
|
@lukas-aron-bcgdv and @vboulineau - thank you for the feedback. I have made the necessary changes. |
|
I'll merge manually as the .lock file needs to be generated with Helm2. |
vboulineau
approved these changes
Nov 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
https://kubernetes-charts.storage.googleapis.com is moving to https://charts.helm.sh/stable and on Nov 13, 2020, the chart downloads will be redirected to the read-only archive GitHub Pages of helm charts (Please see: https://helm.sh/blog/charts-repo-deprecation/). This redirection can possibly cause some disruption. Given that the upstream resolution at kubernetes/kube-state-metrics#1153 might not happen before Nov 13, moving to https://charts.helm.sh/stable might be a safer option in the interim
Which issue this PR fixes
Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
.github/helm-docs.sh)CHANGELOG.mdhas beed updatedREADME.md