New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support custom configs #49
Conversation
Thanks for the PR. I think a few minor changes would be helpful:
|
@jyee thanks for review. I've added support for Could you check it once again, please? |
thanks for implementing this! |
extra/datadog.sh
Outdated
filename=$(basename -- "$file") | ||
filename="${filename%.*}" | ||
mkdir -p "$DD_CONF_DIR/conf.d/${filename}.d" | ||
cp $file "$DD_CONF_DIR/conf.d/${filename}.d/conf.yml" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nit, but let's keep the extension as .yaml, not .yml
extra/datadog.sh
Outdated
cp $file "$DD_CONF_DIR/conf.d/${filename}.d/conf.yml" | ||
done | ||
|
||
for file in "$APP_DATADOG_CHECKS_DIR"/*.yaml; do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I should have been a bit more clear. I was just asking for the change on line 30.
The checks.d
dir contains python files that correspond to the yaml files and they'll also need to be added to the python path (logic around line 82). Let's keep this commit short and delete line 31 and this section. I can merge the config file part and we can work on adding logic bits in a separate PR.
Thanks again for all your work on this!
110ce69
to
c8299da
Compare
@jyee I've made changes according to your suggestions. We can add |
Thanks again! |
This simple change allows to provide additional DataDog configuration in the
datadog
folder in root of the application.For testing on Heroku we can use this buildpack using
https://github.com/DataDog/heroku-buildpack-datadog.git#custom-datadog
URL.