Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use updated/renamed version of acorn-import-assertions (security fix) #70

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

jackwhelpton
Copy link
Contributor

This dependency appears to have been renamed since 1.9.0: observe that github.com/xtuc/acorn-import-assertions redirects to https://github.com/xtuc/acorn-import-attributes.

In 1.9.2 a security vulnerability was addressed (fully qualifying a package reference to prevent a confusion attack), which is being introduced into our codebase via this repo (by way of dd-trace).

Validated that all current tests still pass with this update.

@cedricvanrompay-datadog

I had a look at https://www.npmjs.com/package/acorn-import-assertions and https://www.npmjs.com/package/acorn-import-attributes: as far as I can tell, this seems to be a legitimate change of package name, still controlled by the same maintainer.

@Qard
Copy link
Member

Qard commented Apr 22, 2024

Yeah, the rename of the module is because the proposal for the spec was renamed.

@jackwhelpton
Copy link
Contributor Author

jackwhelpton commented Apr 23, 2024

Any chance of a rough ETA for getting this reviewed/in, a new version cut and dd-trace-js updated? Our security folks are pushing us on this one and I'd like to be able to give them a rough guide on how long it'll take us to mitigate.

Would you like me to update package.json to 1.7.4 in this branch, or is versioning/tagging/publishing handled separately?

@bengl bengl merged commit cbac355 into nodejs:main Apr 30, 2024
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants