feat: Add Hook named export
#88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
approved these changes
May 29, 2024
|
should we also update the README to make the named export the recommended usage? |
trentm
approved these changes
May 29, 2024
3 tasks
|
@timfish should there best test additions too? I.e. if something's exported, it should be tested that that interface works? |
I modified both an ESM and CJS test to use this new export! |
Oops! I should have noticed that. 😅 And I see that other test files retain the usage of the default export. SGTM/LGTM. |
bengl
approved these changes
May 31, 2024
Merged
bengl
added a commit
that referenced
this pull request
May 31, 2024
$ git log --oneline --no-decorate v1.7.4..HEAD 9269d1f 1.8.0 74124e9 fix: handling of default and star exports (#85) 7fa4e9c Fix resolution of lib/register.js when using multiple loaders (#76) e7f05ca add node 22 to test matrix (#84) fb0e393 feat: Add `Hook` named export (#88) bef32f2 chore: don't create a package-lock file (#67) bf3a4fb fix: Resolve re-exports of external modules (#78) 0d9f351 fix: Handle cyclical reference to current file (#83) 1e05e4b test: skip static-import on > v21 (#81)
bengl
pushed a commit
that referenced
this pull request
Jun 14, 2024
In #88 I added a named `Hook` export but forgot to update the TypeScript types!
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
import-in-the-middlehas some ESM interop issues.From here:
This causes issues with some bundlers. Obviously bundled imports will not go through
import-in-the-middlebut using it should not inhibit bundlers as iitm can still hook build-in modules.This PR adds a
Hooknamed export and changes one cjs and esm test to use that new export.