[postfix] Run the check as postfix user, not root #619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hush-hush
requested changes
Jul 24, 2017
postfix/check.py
Outdated
| @@ -61,7 +63,8 @@ def _get_queue_count(self, directory, queues, tags): | |||
| # can dd-agent user run sudo? | |||
| test_sudo = os.system('setsid sudo -l < /dev/null') | |||
| if test_sudo == 0: | |||
| output, _, _ = get_subprocess_output(['sudo', 'find', queue_path, '-type', 'f'], self.log, False) | |||
| postfix_user = self.init_config.get('postfix_user') | |||
There was a problem hiding this comment.
without default value the new check will not work with an old configuration (ie: without the postfix_user). I believe that would be a breaking change (and the new version indicate a minor change). We should add a default value (root for backward compatibility ?)
|
Can we show the new option in the conf example in README, as well? |
hush-hush
approved these changes
Jul 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
No need to run
findasroot, let'ssudo -u postfixinstead.The actual user name for the postfix user is configurable to avoid to hardcode it.
Motivation
Improve the check security wise
Versioning
manifest.jsonCHANGELOG.md