Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Win32_event_log] Add parameter to set default event priority #971

Merged
merged 6 commits into from
Dec 28, 2017

Conversation

dixonscottr
Copy link
Contributor

@dixonscottr dixonscottr commented Dec 27, 2017

What does this PR do?

Allows a default priority level to be set for all events created from the Windows Event Log integration. Currently the default priority level is normal and this allows users to change the priority to low to allow filtering in the event stream.

Motivation

Customer request

Testing Guidelines

An overview on testing
is available in our contribution guidelines.

Versioning

  • Bumped the version check in manifest.json
  • Updated CHANGELOG.md. Please use Unreleased as the date in the title
    for the new section.

Additional Notes

Anything else we should know when reviewing?

derekwbrown
derekwbrown previously approved these changes Dec 28, 2017
Copy link
Contributor

@derekwbrown derekwbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would change the config entry to event_priority, but LGTM. Go ahead and merge after that change.

@dixonscottr dixonscottr added this to the 5.21 milestone Dec 28, 2017
@dixonscottr dixonscottr merged commit 04f36b5 into master Dec 28, 2017
@dixonscottr dixonscottr deleted the scottdixon/event_priority branch December 28, 2017 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants