Add environment variables support for Client configuration #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support of 3 environment variables for Client configuration: - "DD_AGENT_HOST" used to provide the Agent hostname. - "DD_DOGSTATSD_PORT" used to provide the DogStatsD port. - "DD_ENTITY_ID" used to provide an identifier to the Client.
|
@tylerbenson Would you be able to take a look at this? |
|
@xvello Would you be able to take a quick look at this PR. It is the equivalent of DataDog/datadog-go#78 |
gzussa
approved these changes
Mar 18, 2019
tylerbenson
reviewed
Mar 18, 2019
xvello
reviewed
Mar 18, 2019
|
@gzussa business logic and tests LGTM, except one more step of input validation |
This was referenced Mar 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support of 3 environment variables for Client configuration: