Adds testcontainer based JUnit tests #433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottopell
force-pushed
the
sopell/testcontainers
branch
from
42d3289
to
ac63257
Compare
scottopell
force-pushed
the
sopell/testcontainers
branch
from
e61c856
to
847eb13
Compare
scottopell
commented
May 4, 2023
tools/misbehaving-jmx-server/src/main/java/org/datadog/supervisor/App.java
Outdated
Show resolved
Hide resolved
tools/misbehaving-jmx-server/src/main/java/org/datadog/supervisor/App.java
Outdated
Show resolved
Hide resolved
tools/misbehaving-jmx-server/src/main/java/org/datadog/supervisor/App.java
Outdated
Show resolved
Hide resolved
tools/misbehaving-jmx-server/src/main/java/org/datadog/supervisor/App.java
Outdated
Show resolved
Hide resolved
tools/misbehaving-jmx-server/src/main/java/org/datadog/supervisor/App.java
Outdated
Show resolved
Hide resolved
carlosroman
reviewed
May 5, 2023
carlosroman
reviewed
May 5, 2023
carlosroman
reviewed
May 5, 2023
scottopell
commented
May 9, 2023
Co-authored-by: Carlos <carlos.roman@datadoghq.com>
scottopell
force-pushed
the
sopell/testcontainers
branch
from
73f64d3
to
622926c
Compare
…439) * An example of a JMXFetch config and one using AD with Docker labels * Update tools/misbehaving-jmx-server/README.md Co-authored-by: Scott Opell <me@scottopell.com> * Update tools/misbehaving-jmx-server/README.md Co-authored-by: Scott Opell <me@scottopell.com> --------- Co-authored-by: Scott Opell <me@scottopell.com>
carlosroman
previously approved these changes
May 18, 2023
carlosroman
approved these changes
May 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a container-based test to flex the instance recovery subsystem.
Also adds a "misbehaving jmx server" which is a java application exposing a JMX server where you can inject faults into it. See readme of the "misbehaving jmx server" for a list of what it can do today.
TODO
Docker Desktop Notes
Its useful to run the
mvn testexecution itself within a container for docker-desktop. This is because docker-desktop (at least on macos) will run the containers on a VM which is isolated from the host.Example command: