Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assign generic alias if we can't find one - was causing NullPointerEx… #78

Merged
merged 2 commits into from
Oct 20, 2015
Merged

Assign generic alias if we can't find one - was causing NullPointerEx… #78

merged 2 commits into from
Oct 20, 2015

Conversation

truthbk
Copy link
Member

@truthbk truthbk commented Oct 20, 2015

…ception's otherwise..

@yannmh yannmh self-assigned this Oct 20, 2015
@yannmh
Copy link
Member

yannmh commented Oct 20, 2015

Thanks @truthbk, it looks great.

A single nitpick 🎨
Can we take advantage of thism to refactor the method ? I see some redundancies in the alias definition, i.e.
alias = metric_prefix + "." + getBeanStringName().split(":")[0] + "." + getAttributeName(); appearing multiple times.

@truthbk
Copy link
Member Author

truthbk commented Oct 20, 2015

Totally right @yannmh I thought that when I sent the fix to the customer and then totally forgot.

@yannmh
Copy link
Member

yannmh commented Oct 20, 2015

Thanks @truthbk, let's merge it !

🏆JMXFetch first merge achievement 🏆

yannmh added a commit that referenced this pull request Oct 20, 2015
@yannmh
Merge pull request #78 from DataDog/jaime/attrname-fix
f59fec3 
Assign generic alias if we can't find one - was causing NullPointerEx…
@yannmh yannmh merged commit f59fec3 into master Oct 20, 2015
@yannmh yannmh deleted the jaime/attrname-fix branch October 20, 2015 21:58
yannmh added a commit to DataDog/dd-agent that referenced this pull request Nov 3, 2015
@yannmh
[jmxfetch] update to 0.9.0
58b9a9b 
**Changes**
* [BUGFIX] Fix bean name matching logic: `OR`→`AND`. See [#81][]
* [FEATURE] Support `float` and `java.lang.Float` attribute types as
* simple JMX attributes. See [#76][]
* [FEATURE] Support Cassandra > 2.2 metric name structure
* (CASSANDRA-4009). See [#79][]
* [FEATURE] Support custom JMX Service URL to connect to, on a
* per-instance basis. See [#80][]
* [IMPROVEMENT] Assign generic alias if not defined. See [#78][]

<!--- The following link definition list is generated by PimpMyChangelog
--->
[#76]: DataDog/jmxfetch#76
[#78]: DataDog/jmxfetch#78
[#79]: DataDog/jmxfetch#79
[#80]: DataDog/jmxfetch#80
[#81]: DataDog/jmxfetch#81
@yannmh yannmh mentioned this pull request Nov 3, 2015
Merged
urosgruber pushed a commit to urosgruber/dd-agent that referenced this pull request Dec 23, 2015
@yannmh @urosgruber
[jmxfetch] update to 0.9.0
9871968 
**Changes**
* [BUGFIX] Fix bean name matching logic: `OR`→`AND`. See [DataDog#81][]
* [FEATURE] Support `float` and `java.lang.Float` attribute types as
* simple JMX attributes. See [DataDog#76][]
* [FEATURE] Support Cassandra > 2.2 metric name structure
* (CASSANDRA-4009). See [DataDog#79][]
* [FEATURE] Support custom JMX Service URL to connect to, on a
* per-instance basis. See [DataDog#80][]
* [IMPROVEMENT] Assign generic alias if not defined. See [DataDog#78][]

<!--- The following link definition list is generated by PimpMyChangelog
--->
[DataDog#76]: DataDog/jmxfetch#76
[DataDog#78]: DataDog/jmxfetch#78
[DataDog#79]: DataDog/jmxfetch#79
[DataDog#80]: DataDog/jmxfetch#80
[DataDog#81]: DataDog/jmxfetch#81
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@yannmh yannmh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@truthbk @yannmh