Add composer installed.json parsing in sidecar #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bantonsson
reviewed
Mar 5, 2024
bwoebi
force-pushed
the
bob/sidecar-composer-parsing
branch
from
4729701
to
7f81daa
Compare
bantonsson
approved these changes
Mar 5, 2024
bwoebi
force-pushed
the
bob/sidecar-composer-parsing
branch
from
7f81daa
to
8054d90
Compare
Up to now this happened on the tracer side and could be quite expensive. We're moving it to the sidecar so that we can a) apply caching and b) not execute it in the request path of the tracer. Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
bwoebi
force-pushed
the
bob/sidecar-composer-parsing
branch
from
8054d90
to
70bcb48
Compare
bantonsson
pushed a commit
that referenced
this pull request
Mar 25, 2024
* Add composer installed.json parsing in sidecar Up to now this happened on the tracer side and could be quite expensive. We're moving it to the sidecar so that we can a) apply caching and b) not execute it in the request path of the tracer. Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com> * Reduce cache cleans and test it Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com> --------- Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Up to now this happened on the tracer side and could be quite expensive. We're moving it to the sidecar so that we can a) apply caching and b) not execute it in the request path of the tracer.
This brings considerable performance improvements in our benchmarks.