Add 2 Sidecar actions to register and push metrics #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamluc
force-pushed
the
lv/tracer-telemetry
branch
from
2fc0210
to
4bba288
Compare
iamluc
force-pushed
the
lv/tracer-telemetry
branch
from
4bba288
to
dcbc480
Compare
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
bwoebi
force-pushed
the
lv/tracer-telemetry
branch
from
0529476
to
7e5fb64
Compare
bantonsson
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds 2 Sidecar actions:
RegisterTelemetryMetric: Register a new Telemetry metricAddTelemetryMetricPoint: Send a Telemetry metric pointMotivation
This is required for the clients to send telemetry metrics (https://datadoghq.atlassian.net/browse/AIT-4125)
Additional Notes
This is my first PR on libdatadog, and also the first time I write Rust code 😄
How to test the change?
This is tested by a test in a dd-trace-php PR (DataDog/dd-trace-php#2577)
For Reviewers
@DataDog/security-design-and-guidance.