Upgrade to gradle 8.8 nightly #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smola
force-pushed
the
smola/gradle-8.6
branch
3 times, most recently
from
72a396d
to
28e4d38
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #101 +/- ##
============================================
+ Coverage 58.54% 58.55% +0.01%
Complexity 134 134
============================================
Files 34 34
Lines 3459 3458 -1
Branches 781 780 -1
============================================
Hits 2025 2025
Misses 900 900
+ Partials 534 533 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| @@ -133,26 +131,29 @@ location of your Java installation." | |||
| fi | |||
| else | |||
| JAVACMD=java | |||
| which java >/dev/null 2>&1 || die "ERROR: JAVA_HOME is not set and no 'java' command could be found in your PATH. | |||
| if ! command -v java >/dev/null 2>&1 | |||
| @@ -308,7 +308,7 @@ class ByteBufferSerializerTests implements PowerwafTrait { | |||
| void 'observes maximum string size'() { | |||
| maxStringSize = 3 | |||
| // the size is number of UTF-16 code units | |||
| def str = "\uFFFD" * 3 + 'x' | |||
| def str = '\uFFFD' * 3 + 'x' | |||
There was a problem hiding this comment.
People almost never realize that double quotes in Groovy means a GString and it is not a String, it works 99.999% of the time, but when it fails it's usually a pain in the *** 😄
There was a problem hiding this comment.
If I recall correctly, double quotes "..." will be interpreted as GString only there is interpolation (e.g. contains ${...}) otherwise it still will be a Java String.
manuel-alvarez-alvarez
approved these changes
Mar 1, 2024
ValentinZakharov
approved these changes
Mar 1, 2024
* Replace `classifier` (deprecated) with `archiveClassifier`. * Remove UnnecessarySubstring codenarc rule (deprecated). * Fix for UnnecessaryGString codenarc rule. * Ensure copyNativeLibs runs before any task that implicitly depends on it (required by gradle).
smola
force-pushed
the
smola/gradle-8.6
branch
2 times, most recently
from
f396fa1
to
aeec633
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
classifier(deprecated) witharchiveClassifier.