Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ptr typedefs #212

Merged
merged 3 commits into from
Sep 6, 2023
Merged

Remove ptr typedefs #212

merged 3 commits into from
Sep 6, 2023

Conversation

Anilm3
Copy link
Collaborator

@Anilm3 Anilm3 commented Sep 5, 2023

For convenience and reducing characters, I introduced a ptr typedef (using declaration) on certain classes which were typically used as a shared_ptr. Over time the use of this ptr typedef was extended to other classes, some as shared_ptr and some as unique_ptr, which has made it very difficult to understand the underlying pointer type. This PR removes them to make the underlying pointer type more explicit.

@codecov-commenter
Copy link

codecov-commenter commented Sep 5, 2023

Codecov Report

Merging #212 (cbe4028) into master (f0a48e4) will not change coverage.
The diff coverage is 96.00%.

@@           Coverage Diff           @@
##           master     #212   +/-   ##
=======================================
  Coverage   82.58%   82.58%           
=======================================
  Files         105      105           
  Lines        3986     3986           
  Branches     1813     1813           
=======================================
  Hits         3292     3292           
  Misses        281      281           
  Partials      413      413           
Flag Coverage Δ
waf_test_none 82.47% <96.00%> (ø)
waf_test_sse2 82.55% <96.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/collection.cpp 81.81% <ø> (ø)
src/collection.hpp 80.00% <0.00%> (ø)
src/exclusion/input_filter.hpp 100.00% <ø> (ø)
src/exclusion/rule_filter.hpp 100.00% <ø> (ø)
src/generator/base.hpp 100.00% <ø> (ø)
src/matcher/base.hpp 87.50% <ø> (ø)
src/parser/specification.hpp 100.00% <ø> (ø)
src/rule.cpp 100.00% <ø> (ø)
src/rule.hpp 84.00% <ø> (ø)
src/ruleset_builder.cpp 81.65% <ø> (ø)
... and 12 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Anilm3 Anilm3 marked this pull request as ready for review September 6, 2023 07:12
@Anilm3 Anilm3 requested a review from a team as a code owner September 6, 2023 07:12
estringana
estringana previously approved these changes Sep 6, 2023
@Anilm3 Anilm3 merged commit b911740 into master Sep 6, 2023
25 checks passed
@Anilm3 Anilm3 deleted the anilm3/remove-ptr-typedefs branch September 6, 2023 08:23
Copy link
Contributor

@cataphract cataphract left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you wanted to save typing, you could use typedefs like uptr and sptr, but this is fine too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants