Vendorize re2 and utf8proc #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov Report
@@ Coverage Diff @@
## master #231 +/- ##
=======================================
Coverage 83.23% 83.23%
=======================================
Files 106 106
Lines 4176 4176
Branches 1914 1914
=======================================
Hits 3476 3476
Misses 279 279
Partials 421 421
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
estringana
approved these changes
Nov 13, 2023
cataphract
approved these changes
Nov 15, 2023
Funny that you mention that, I was thinking the same thing and refactored the main CMakeLists in #232 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vendorise remaining dependencies of
libddwaf.so/a. This will eventually make it simpler (and more efficient) to support LTO and it has also allowed us to remove some unnecessary RE2 features.