Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add weak ceilf symbol and definition #263

Merged
merged 20 commits into from
Feb 16, 2024
Merged

Add weak ceilf symbol and definition #263

merged 20 commits into from
Feb 16, 2024

Conversation

Anilm3
Copy link
Collaborator

@Anilm3 Anilm3 commented Feb 13, 2024

Add weak ceilf symbol for systems in which ceilf isn't readily available.

@codecov-commenter
Copy link

codecov-commenter commented Feb 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (961551e) 82.46% compared to head (9d7360e) 82.46%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #263   +/-   ##
=======================================
  Coverage   82.46%   82.46%           
=======================================
  Files         112      112           
  Lines        4301     4301           
  Branches     1971     1971           
=======================================
  Hits         3547     3547           
  Misses        306      306           
  Partials      448      448           
Flag Coverage Δ
waf_test_none 82.35% <ø> (ø)
waf_test_sse2 82.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pr-commenter
Copy link

pr-commenter bot commented Feb 13, 2024

Benchmarks

Benchmark execution time: 2024-02-16 09:14:15

Comparing candidate commit 9d7360e in PR branch anilm3/override-ceilf with baseline commit 961551e in branch master.

Found 9 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 0 unstable metrics.

scenario:bool_equals_matcher.random

  • 🟩 execution_time [-50.928µs; -50.000µs] or [-4.684%; -4.599%]

scenario:exact_match_matcher.random

  • 🟩 execution_time [-79.374µs; -78.428µs] or [-5.256%; -5.194%]

scenario:float_equals_matcher.random

  • 🟩 execution_time [-71.023µs; -70.028µs] or [-6.467%; -6.376%]

scenario:ip_match_matcher.random

  • 🟩 execution_time [-68.657µs; -67.659µs] or [-4.794%; -4.724%]

scenario:lowercase_transformer.random

  • 🟩 execution_time [-76.635µs; -75.769µs] or [-4.594%; -4.542%]

scenario:regex_match_matcher.random

  • 🟩 execution_time [-87.547µs; -86.504µs] or [-4.454%; -4.401%]

scenario:signed_equals_matcher.random

  • 🟩 execution_time [-55.968µs; -54.276µs] or [-5.140%; -4.985%]

scenario:string_equals_matcher.random

  • 🟩 execution_time [-60.390µs; -57.951µs] or [-4.468%; -4.288%]

scenario:unsigned_equals_matcher.random

  • 🟩 execution_time [-52.000µs; -51.237µs] or [-4.802%; -4.732%]

@Anilm3 Anilm3 marked this pull request as ready for review February 13, 2024 16:12
@Anilm3 Anilm3 requested a review from a team as a code owner February 13, 2024 16:12
@Anilm3 Anilm3 merged commit 2931993 into master Feb 16, 2024
25 checks passed
@Anilm3 Anilm3 deleted the anilm3/override-ceilf branch February 16, 2024 09:28
Anilm3 added a commit that referenced this pull request Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants