Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert non-string object types into string during ruleset parsing #285

Merged
merged 3 commits into from
Apr 23, 2024

Conversation

Anilm3
Copy link
Collaborator

@Anilm3 Anilm3 commented Apr 23, 2024

This PR introduces a small change to convert string-compatible objects into string during the parsing stage. The yaml-to-object converter used for testing was also fixed to account for non-string types.

Note that parameter.{cpp,hpp} will be removed in v2.

@Anilm3 Anilm3 marked this pull request as ready for review April 23, 2024 15:07
@Anilm3 Anilm3 requested a review from a team as a code owner April 23, 2024 15:07
@Anilm3 Anilm3 changed the title Convert non-string object types into string Convert non-string object types into string during ruleset parsing Apr 23, 2024
@pr-commenter
Copy link

pr-commenter bot commented Apr 23, 2024

Benchmarks

Benchmark execution time: 2024-04-23 15:28:17

Comparing candidate commit 4262d6a in PR branch anilm3/non-string-action-parameters with baseline commit f6ca86d in branch master.

Found 9 performance improvements and 1 performance regressions! Performance is the same for 9 metrics, 0 unstable metrics.

scenario:bool_equals_matcher.random

  • 🟩 execution_time [-61.106µs; -59.908µs] or [-5.263%; -5.160%]

scenario:exact_match_matcher.random

  • 🟩 execution_time [-64.070µs; -63.096µs] or [-4.241%; -4.176%]

scenario:float_equals_matcher.random

  • 🟩 execution_time [-54.394µs; -53.579µs] or [-4.686%; -4.616%]

scenario:ip_match_matcher.random

  • 🟩 execution_time [-47.099µs; -46.190µs] or [-3.141%; -3.080%]

scenario:phrase_match_matcher.enforce_word_boundary.random

  • 🟥 execution_time [+2.433ms; +2.435ms] or [+41.053%; +41.085%]

scenario:phrase_match_matcher.random

  • 🟩 execution_time [-237.684µs; -234.660µs] or [-3.711%; -3.664%]

scenario:regex_match_matcher.random

  • 🟩 execution_time [-140.136µs; -139.206µs] or [-7.211%; -7.163%]

scenario:remove_nulls_transformer.random

  • 🟩 execution_time [-1.265ms; -1.262ms] or [-11.867%; -11.846%]

scenario:signed_equals_matcher.random

  • 🟩 execution_time [-56.231µs; -55.041µs] or [-4.850%; -4.747%]

scenario:string_equals_matcher.random

  • 🟩 execution_time [-43.099µs; -42.054µs] or [-3.093%; -3.018%]

@Anilm3 Anilm3 merged commit 2fcd3cf into master Apr 23, 2024
35 checks passed
@Anilm3 Anilm3 deleted the anilm3/non-string-action-parameters branch April 23, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants