-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SHA256 hash based on OpenSSL #304
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #304 +/- ##
==========================================
+ Coverage 83.39% 83.66% +0.27%
==========================================
Files 135 137 +2
Lines 5854 6007 +153
Branches 2808 2829 +21
==========================================
+ Hits 4882 5026 +144
- Misses 361 366 +5
- Partials 611 615 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
BenchmarksBenchmark execution time: 2024-06-17 19:31:06 Comparing candidate commit fae4113 in PR branch Found 2 performance improvements and 0 performance regressions! Performance is the same for 17 metrics, 0 unstable metrics. scenario:signed_equals_matcher.random
scenario:unsigned_equals_matcher.random
|
Benchmarked three different variants:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine. As mentioned, it would interesting to see a version using instructions dedicated to it (SHA256H/SHA256H2/SHA256SU0/SHA256SU1 for aarch64) and SHA256MSG1/SHA256MSG2/SHA256RNDS2 for amd64.
This PR introduces a class to compute the sha256 digest, the code is based on the openssl implementation. At first, the objective is to use this hash for request fingerprinting purposes, however it could be used for other purposes: