trace: use /v0.4 agent endpoint and priority sampling #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbbr
force-pushed
the
gbbr/priority-sampling
branch
5 times, most recently
from
e34103d
to
2096a96
Compare
gbbr
force-pushed
the
gbbr/priority-sampling
branch
from
2096a96
to
a786a57
Compare
gbbr
force-pushed
the
gbbr/priority-sampling
branch
from
7daac84
to
7f668c5
Compare
ufoot
reviewed
Jan 3, 2019
|
@ufoot thanks a lot. Addressed your comments, PTAL |
ufoot
approved these changes
Jan 4, 2019
| for { | ||
| select { | ||
| case span := <-e.in: | ||
| e.receiveSpan(span) |
There was a problem hiding this comment.
Thank you too for being the catalyst in making me think deeper! 🙇
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change enables the use of the agent's /v0.4 endpoint and enables priority sampling by default.
sampler.goandsampler_test.goare copied from dd-trace-go@1.8.0