8313816: Accessing jmethodID might lead to spurious crashes (1)

DataDog · Aug 7, 2023 · 61405d4 · 61405d4
1 parent 90d795a
commit 61405d4
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/.github/actions/do-build/action.yml b/.github/actions/do-build/action.yml
@@ -60,6 +60,7 @@ runs:
               $build_dir/configure.log \
               $build_dir/make-support/failure-summary.log \
               $build_dir/make-support/failure-logs/* \
+              $build_dir/make/hs_err*.log \
               failure-logs/ 2> /dev/null || true
           echo 'failure=true' >> $GITHUB_OUTPUT
         fi

diff --git a/src/hotspot/share/oops/instanceKlass.cpp b/src/hotspot/share/oops/instanceKlass.cpp
@@ -2828,6 +2828,12 @@ void InstanceKlass::release_C_heap_structures(bool release_sub_metadata) {
   jmethodID* jmeths = methods_jmethod_ids_acquire();
   if (jmeths != (jmethodID*)nullptr) {
     release_set_methods_jmethod_ids(nullptr);
+    size_t count = (size_t)jmeths[0];
+    fprintf(stderr, "===> releasing %lu jmethodids\n", count);
+//    for (size_t i = 1; i <= count; i++) {
+//      *((Method**)jmeths[i]) = nullptr;
+//    }
+    memset(jmeths, 0, count * sizeof(jmethodID));
     FreeHeap(jmeths);
   }