Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove root span and max_nested_level #19

Merged
merged 7 commits into from
Jun 10, 2024
Merged

Remove root span and max_nested_level #19

merged 7 commits into from
Jun 10, 2024

Conversation

bonnefoa
Copy link
Collaborator

Root span in the trace_context was used to deal with the extended protocol + transaction block issue: The parse of the next statement happens while the previous statement is ongoing since the portal is only dropped during the bind command.
We can replace it by a specific next_active_span to store span's information when we hit this case and restore it when needed.
We also remove max_nested_level: we can track whether pg_tracing memory context is allocated by checking pg_tracing_mem_ctx->isReset, making max_nested_level redundant.

@bonnefoa bonnefoa merged commit 938161b into main Jun 10, 2024
3 checks passed
@bonnefoa bonnefoa deleted the remove-root-span branch June 10, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant