Remove root span and max_nested_level #19
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Root span in the trace_context was used to deal with the extended protocol + transaction block issue: The parse of the next statement happens while the previous statement is ongoing since the portal is only dropped during the bind command.
We can replace it by a specific next_active_span to store span's information when we hit this case and restore it when needed.
We also remove max_nested_level: we can track whether pg_tracing memory context is allocated by checking pg_tracing_mem_ctx->isReset, making max_nested_level redundant.