Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update extension requirements #80

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update extension requirements #80

wants to merge 1 commit into from

Conversation

nCrazed
Copy link

@nCrazed nCrazed commented Feb 10, 2019

As far as I can tell ever since #31 ext-curl is not used in the default configuration. As such it should be marked optional.

As far as I can tell ever since #31 `ext-curl` is not used in the default configuration. As such it should be marked optional.
@nCrazed
Copy link
Author

nCrazed commented Feb 10, 2019

Similarly ext-sockets should be added (although it is currently unclear to me if it's required for API call use cases.

While PHP usually compiled with sockets by default, it is not the case in docker environments where using this package without explicitly enabling the extension will crash the application at run-time.

@SammyK
Copy link
Contributor

SammyK commented Sep 20, 2019

Thanks for the contribution @nCrazed! Sorry for the delay on responding to this.

I'm all for moving curl to a suggestion. Before we do, we'll need to handle the case where curl is not installed and the user has not configured UDP. Perhaps we check for extension_loaded('curl') here and possibly fall back to UDP if curl is not installed? There might be better options so if you have a better idea, feel free to chime in. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants