v2.0.5 proposal #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Avoid making StringTable inherit from Array, this seems dangerous as one could `push` directly without updating the internal structures * StringTable has an optional `tok` argument that triggers creation of an empty table if constant `emptyTableToken`is passed, otherwise the empty string is insrted in the constructor * ProfileInput.stringTable only accepts StringTable * During decoding, `ProfileInput.stringTable` is created empty and elements are inserted with `_decodeString` * If `Profile` is constructed without defining `ProfileInput.stringTable`, a string table containing only the empty string will be constructed * `StringTable.#encodings` have been converted from a Map to an Array since it can be indexed by position * During decoding, `StringTable.encodings` is still recomputed (which is a bit inefficient since it has just been deserialized) but string utf8 encoding is reused
Overall package sizeSelf size: 164.74 kB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Qard
approved these changes
Jan 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I propose to stay on the v2.x line since the changes done do not change the API.