Add support for node 22 #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Overall package sizeSelf size: 7.42 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Qard
previously approved these changes
Apr 30, 2024
With node 22, many deopt events are generated by `setContext` call in `fn0`. On MacOS, `v8::TimeTicks::Now` has a resolution of ~42us because `mach_absolute_time` ticks (a tick is ~42ns) conversion to microseconds is done in such a way that drops the 3 least significant digits. This two facts lead to samples having identical timestamps, and incorrectly matched contexts. Workaround here just ensures that after deopt event caused by `setContext`, no sample in `fn1` is immediately taken.
szegedi
approved these changes
May 8, 2024
nsavoire
added a commit
that referenced
this pull request
May 8, 2024
* Test on node 22 * Test improvements * Update nan to 2.19.0 for Node 22 * Fix wall profiler test for node 22 on MacOS With node 22, many deopt events are generated by `setContext` call in `fn0`. On MacOS, `v8::TimeTicks::Now` has a resolution of ~42us because `mach_absolute_time` ticks (a tick is ~42ns) conversion to microseconds is done in such a way that drops the 3 least significant digits. This two facts lead to samples having identical timestamps, and incorrectly matched contexts. Workaround here just ensures that after deopt event caused by `setContext`, no sample in `fn1` is immediately taken. * Fix eslint warning --------- Co-authored-by: Attila Szegedi <attila.szegedi@datadoghq.com>
nsavoire
added a commit
that referenced
this pull request
May 16, 2024
* Test on node 22 * Test improvements * Update nan to 2.19.0 for Node 22 * Fix wall profiler test for node 22 on MacOS With node 22, many deopt events are generated by `setContext` call in `fn0`. On MacOS, `v8::TimeTicks::Now` has a resolution of ~42us because `mach_absolute_time` ticks (a tick is ~42ns) conversion to microseconds is done in such a way that drops the 3 least significant digits. This two facts lead to samples having identical timestamps, and incorrectly matched contexts. Workaround here just ensures that after deopt event caused by `setContext`, no sample in `fn1` is immediately taken. * Fix eslint warning --------- Co-authored-by: Attila Szegedi <attila.szegedi@datadoghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add asan/valgrind tests on node 22.
Add workaround for wall profiler test on node 22 / MacOS.