Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests for integration classes #145

Closed
wants to merge 22 commits into from

Conversation

kitchen
Copy link
Contributor

@kitchen kitchen commented Nov 18, 2015

these are tests for the integration classes.

I have left out 2 integrations:

  1. datadog_agent::integration::directory

    This integration doesn't appear to be functional. Catalogs which include it cannot compile. I've opened an issue at datadog_agent::integrations::directory is not functional? #144 for this.

  2. datadog_agent::integration::generic

    The work I plan to do next on this will obviate the need for the 'generic' integration, so it didn't make sense adding tests for something that's going to go away Real Soon Now™

@kitchen
Copy link
Contributor Author

kitchen commented Nov 18, 2015

I made each test into a separate commit for easier perusal of the changes related to that test. I can squash this before merging if necessary.

@talwai
Copy link
Contributor

talwai commented Jan 11, 2016

@kitchen looks great, thanks for your efforts! We'll be reviewing this more thoroughly shortly, and have it slated for an upcoming release

@talwai talwai added this to the triage milestone Jan 11, 2016
@irabinovitch
Copy link

@truthbk Will we be able to pull these test improvements into 1.7.0 as well? (#176)

@truthbk
Copy link
Member

truthbk commented Apr 12, 2016

Yup, put these into #176, some had to be slightly modified due to changes that were brought in other PR's, but these are great! Thanks a lot @kitchen, big boost for us in the spec coverage. Much appreciated.

@truthbk truthbk closed this Apr 13, 2016
@truthbk
Copy link
Member

truthbk commented Apr 13, 2016

@kitchen just wanted to let you know there was a typo in the changelog that shipped with the released puppet module 1.7.0 that failed to recognize your contribution, it's already been fixed in github and will be corrected in subsequent releases. My apologies for the oversight, your changes were the last I added andI forgot to update before releasing 😞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants