Support generic postgres custom metrics

[sethcleveland]

No description provided.

[sethcleveland]

Dropping in puppet support for the following -- https://help.datadoghq.com/hc/en-us/articles/208385813-Postgres-custom-metric-collection-explained

[truthbk]

Could you please add an example with custom metrics below? Should help a bit with usability.

[truthbk]

Thanks a lot @sethcleveland, tackles an open issue which is always greatly appreciated! If you could add some spec tests that'd be fabulous.

[sethcleveland]

Sure thing. This is an open issue for us as well. I'll add documentation and spec tests.

[sethcleveland]

I did a brief scan on the failures and most things appear to fail this. --

bundle exec rake test
---> syntax:manifests
---> syntax:templates
---> syntax:hiera:yaml
manifests/integrations/mysql.pp:41:parameter_order:WARNING:optional parameter listed before required parameter
manifests/integrations/pgbouncer.pp:31:parameter_order:WARNING:optional parameter listed before required parameter
manifests/integrations/postgres.pp:56:parameter_order:WARNING:optional parameter listed before required parameter

I didn't make those changes. As far as I can tell they are the status quo.

[sethcleveland]

@truthbk: How are these changes?

[truthbk]

@sethcleveland this is great, thanks a lot. I'll review in a little bit more depth before merging, but it looks good. I'll keep you posted! I need to understand where those failures are coming from. Maybe if you rebase to the latest master we can get rid of them..... :)

[sethcleveland]

@truthbk just rebased against master. Hopefully that fixes the problems.

[sethcleveland]

@truthbk turns out rebasing against master didn't resolve the failures. I'm assuming the linters were added after the fact. I fixed the failing builds as part of this PR commit -- 5cd38a4.

FWIW's I'm not clear why parameter optional/non-optional parameter ordering matters. I've only see puppet modules used with explicit parameter values.

[rooprob]

Hi,

Can we split out and merge 5cd38a4 as it's blocking PRs such as #231 and #229.

[sethcleveland]

@truthbk do these changes work? Other people can be unblocked by one of the commits. I can cherry pick the fix out into another PR while you spend more time reviewing these changes. Let me know where you'll stand before I make another PR.

[sethcleveland]

@rooprob I cherry-picked that commit and made a PR here -- #232.

[mcasper]

Isn't this a hash of custom metrics?

[sethcleveland]

Yup. I'll make an adjustment.

[truthbk]

@sethcleveland thank you so much for this and #232 - merging this in. Again, apologies for the long MTTR.