Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for the JMX integration #231

Merged
merged 1 commit into from
Nov 8, 2016
Merged

Add support for the JMX integration #231

merged 1 commit into from
Nov 8, 2016

Conversation

rooprob
Copy link
Contributor

@rooprob rooprob commented Sep 8, 2016

This was referenced Sep 12, 2016
Closed
Merged
Merged
@truthbk
Copy link
Member

truthbk commented Sep 20, 2016

Hi @rooprob! Thank you for adding this. It looks almost ready for merging, other than the rebase that was pending given the fix in #232 - I've just merged it.

@rooprob rooprob force-pushed the feature/add_jmx branch 2 times, most recently from 61b363a to 2fc5abd Compare September 20, 2016 17:58
@williamtsoi1
Copy link

Hi, looks like this is good to merge now? I'm in need of this integration. Thanks!

@rooprob
Copy link
Contributor Author

rooprob commented Nov 4, 2016

Hi @truthbk
Is there anything else I need to do to get this merged?
cheers,

@truthbk truthbk merged commit 643d5b1 into DataDog:master Nov 8, 2016
cegeka-jenkins pushed a commit to cegeka/puppet-datadog_agent that referenced this pull request Jan 31, 2018
@truthbk
Merge pull request DataDog#231 from rooprob/feature/add_jmx
49b72a8 
Add support for the JMX integration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rooprob @truthbk @williamtsoi1