Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change unless -> not #558

Merged
merged 2 commits into from
Sep 3, 2019
Merged

Change unless -> not #558

merged 2 commits into from
Sep 3, 2019

Conversation

albertvaka
Copy link
Contributor

@albertvaka albertvaka commented Sep 3, 2019 •
edited
Loading

unless starts a new conditional block, so we needed an extra end keyword (which was incorrectly nested).

@albertvaka
Change unless -> not
def93a1 
Unless starts a new conditional block, so we needed an extra end keyword.
@albertvaka albertvaka mentioned this pull request Sep 3, 2019
Closed
truthbk
truthbk reviewed Sep 3, 2019
View reviewed changes
Copy link
Member

@truthbk truthbk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a tiny spec test to catch this (previously) broken scenario? It would've been nice to have caught this earlier with the tests (I think this was me introducing it too).

Other than that, LGTM.

@albertvaka albertvaka merged commit 425a6bf into master Sep 3, 2019
@albertvaka albertvaka deleted the albertvaka/fix-double-end branch September 3, 2019 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@truthbk truthbk truthbk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@albertvaka @truthbk