[datadog-report] m could be nil, breaking reporting. Fix gem provider.
#211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
truthbk
changed the title
m could be nil, breaking reporting.
truthbk
changed the title
m could be nil, breaking reporting.m could be nil, breaking reporting. Fix gem provider.
truthbk
force-pushed
the
jaime/fixmetrics
branch
from
776c212
to
2794b7c
Compare
No need to rely on `puppetserver_gem` for the gems, as its not server-side.
truthbk
force-pushed
the
jaime/fixmetrics
branch
from
2794b7c
to
7ac92d8
Compare
|
lgtm |
cegeka-jenkins
pushed a commit
to cegeka/puppet-datadog_agent
that referenced
this pull request
Jan 31, 2018
[datadog-report] `m` could be nil, breaking reporting. Fix gem provider.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reporting could potentially break if m happened to be nil.
Also, because the reporting code will indeed run on the agent (as tested on
4.5.1) we don't need to rely on thepuppetserver_gem(required to install gems on the JRuby environment on thepuppetserverwhen code runs on the server-side).Also improves a bit on #210 so we can better spec-test for it (making dogapi_version a parameter for the
reportssubmodule), and perhaps change the source of thedogapi_versionin the future.