Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support use_pscopg2 flag for postgres integrations #243

Conversation

sethcleveland
Copy link
Contributor

No description provided.

@sethcleveland
Copy link
Contributor Author

Closing the loop with this PR -- DataDog/dd-agent#2782.

@sethcleveland
Copy link
Contributor Author

@truthbk is there anything I can do to get this merged in?

@truthbk
Copy link
Member

truthbk commented Nov 8, 2016

@sethcleveland apologies, I was out for a few days. Changes are straight-forward, but I see some tests are failing. You might want to rebase to the latest master and see if that fixes anything? If you don't have the time to fix the broken tests, let me know.

@sethcleveland sethcleveland force-pushed the support_use_psycopg2_postgres_integrations_flag branch from 04557eb to 1d92be7 Compare November 9, 2016 16:02
@sethcleveland
Copy link
Contributor Author

@truthbk looks like the rebase worked. Thanks!

@truthbk truthbk merged commit 7d8bd03 into DataDog:master Nov 14, 2016
@truthbk
Copy link
Member

truthbk commented Nov 14, 2016

thanks @sethcleveland merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants