New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added multiple postgres instances and fixed pgbouncer #372
Conversation
Just for reference/testing, here's an example to declare multiple postgres instances in hiera for a node
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is mostly great. Thank you so much @rothgar 🙇
It would be awesome if we could update the spec tests to cover the case where we pass an array of instances.
There's also a small stylistic issue on postgres.pp:96
manifests/integrations/postgres.pp
Outdated
$_instances = $instances | ||
} | ||
|
||
file { "$dst": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line has a minor stylistic issue:
manifests/integrations/postgres.pp:96:only_variable_string:WARNING:string containing only a variable
manifests/integrations/postgres.pp:96:variables_not_enclosed:WARNING:variable not enclosed in {}
The line was originally:
file { $dst:
which I think is fine, but if you have your reasons for changing that you might have to address it some other way.
I reverted the file definition. Do you know of an example for testing passing an array of instances? I looked in the mysql tests but didn't see a test for an array so I'm not sure how to do it. |
@rothgar that's OK, I'm working on puppet right now, so I'll add the tests to the suite myself - there are tests for |
* Added postgress instances and fixed pgbouncer * Revert file name variable quoting
This fixes a problem with pgbouncer class not including the datadog_agent (error if not otherwise included)
It also allows multiple postgres instances on the same node. It's based on the mysql template and manifest but now can be applied to postgres.