Only download MSI if needed #563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
albertvaka
commented
Sep 20, 2019
•
albertvaka
commented
- Only download MSI if needed (ie: agent is not installed and MSI not downloaded already)
- Use system's temp directory instead of creating our own.
KSerrania
approved these changes
Oct 3, 2019
Use system's temp directory instead of creating our own.
albertvaka
force-pushed
the
albertvaka/download-msi-conditional
branch
from
87e658d
to
a66b7a8
Compare
derekwbrown
reviewed
Oct 3, 2019
| @@ -7,7 +7,7 @@ | |||
| String $agent_version = $datadog_agent::params::agent_version, | |||
| String $service_ensure = 'running', | |||
| String $baseurl = $datadog_agent::params::agent6_default_repo, | |||
| String $msi_location = 'c:/tmp', | |||
| String $msi_location = 'C:/Windows/temp', | |||
There was a problem hiding this comment.
This should probably be %TEMP% (i.e. the TEMP environment variable
There was a problem hiding this comment.
Unfortunately there isn't a straightforward way of using env vars in puppet. Since Puppet runs as admin, I think this is good enough and we can try to get it right on a separate PR. I agree it can fail (eg: Windows installed somewhere else).
cegeka-jenkins
pushed a commit
to cegeka/puppet-datadog_agent
that referenced
this pull request
Apr 6, 2020
…onditional Only download MSI if needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.