-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor interpreter evaluation #137
Open
Kyle-Verhoog
wants to merge
8
commits into
DataDog:master
Choose a base branch
from
Kyle-Verhoog:interp-lookup
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on May 16, 2021
-
Refactor interpreter evaluation
Before, interpreter evaluation was done at run-time when the interpreter was first used. With this patch interpreters are looked up when the environments are generated. Also, more precise interpreter specification is possible. Before, specifying "3" in a riotfile would result in a "python3" executable being looked up. So riot would fail if Python was installed as "python" and no "python3" executable was available on the path. Now interpreters can be specified with a file path, executable name or a version (which will be looked up on the PATH).
Configuration menu - View commit details
-
Copy full SHA for 2801dbb - Browse repository at this point
Copy the full SHA 2801dbbView commit details
Commits on May 21, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 40a8de4 - Browse repository at this point
Copy the full SHA 40a8de4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 36e1d19 - Browse repository at this point
Copy the full SHA 36e1d19View commit details -
Configuration menu - View commit details
-
Copy full SHA for 68ef1cd - Browse repository at this point
Copy the full SHA 68ef1cdView commit details -
interpreter_version -> interpreter_hint
A bit more clear that the "version" is not necessarily a version.
Configuration menu - View commit details
-
Copy full SHA for 63af679 - Browse repository at this point
Copy the full SHA 63af679View commit details
Commits on May 22, 2021
-
CmdFailure was overloaded to handle two different error cases which was confusing.
Configuration menu - View commit details
-
Copy full SHA for 65a1b55 - Browse repository at this point
Copy the full SHA 65a1b55View commit details -
Fix list with missing interpreters
Print out the venv explicitly saying that the specified interpreter is missing.
Configuration menu - View commit details
-
Copy full SHA for 7f4eca3 - Browse repository at this point
Copy the full SHA 7f4eca3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6724866 - Browse repository at this point
Copy the full SHA 6724866View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.