Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor interpreter evaluation #137

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Commits on May 16, 2021

  1. Refactor interpreter evaluation

    Before, interpreter evaluation was done at run-time when the interpreter
    was first used.
    
    With this patch interpreters are looked up when the environments are
    generated.
    
    Also, more precise interpreter specification is possible. Before,
    specifying "3" in a riotfile would result in a "python3" executable
    being looked up. So riot would fail if Python was installed as "python"
    and no "python3" executable was available on the path.
    
    Now interpreters can be specified with a file path, executable name
    or a version (which will be looked up on the PATH).
    Kyle-Verhoog committed May 16, 2021
    Configuration menu
    Copy the full SHA
    2801dbb View commit details
    Browse the repository at this point in the history

Commits on May 21, 2021

  1. Inline return

    Kyle-Verhoog committed May 21, 2021
    Configuration menu
    Copy the full SHA
    40a8de4 View commit details
    Browse the repository at this point in the history
  2. Atomic directory read

    Kyle-Verhoog committed May 21, 2021
    Configuration menu
    Copy the full SHA
    36e1d19 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    68ef1cd View commit details
    Browse the repository at this point in the history
  4. interpreter_version -> interpreter_hint

    A bit more clear that the "version" is not necessarily a version.
    Kyle-Verhoog committed May 21, 2021
    Configuration menu
    Copy the full SHA
    63af679 View commit details
    Browse the repository at this point in the history

Commits on May 22, 2021

  1. Refactor run with RunFailure

    CmdFailure was overloaded to handle two different error cases which was
    confusing.
    Kyle-Verhoog committed May 22, 2021
    Configuration menu
    Copy the full SHA
    65a1b55 View commit details
    Browse the repository at this point in the history
  2. Fix list with missing interpreters

    Print out the venv explicitly saying that the specified interpreter is
    missing.
    Kyle-Verhoog committed May 22, 2021
    Configuration menu
    Copy the full SHA
    7f4eca3 View commit details
    Browse the repository at this point in the history
  3. Fix generate venvs

    Kyle-Verhoog committed May 22, 2021
    Configuration menu
    Copy the full SHA
    6724866 View commit details
    Browse the repository at this point in the history