Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose DD_SERVERLESS_LOGS_ENABLED env var, bump deps #146

Merged
merged 10 commits into from Jul 15, 2021
Merged

Expose DD_SERVERLESS_LOGS_ENABLED env var, bump deps #146

merged 10 commits into from Jul 15, 2021

Conversation

astuyve
Copy link
Contributor

@astuyve astuyve commented Jul 13, 2021 •
edited

What does this PR do?

  1. Bumps critical deps via yarn audit --fix
  2. honors enableDDLogs in config and DD_SERVERLESS_LOGS_ENABLED in environment:
    image
    (I also verified that it's false when specified)

Motivation

Testing Guidelines

Additional Notes

Types of changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog

@astuyve astuyve requested a review from a team as a code owner July 13, 2021 22:18
@codecov-commenter
Copy link

codecov-commenter commented Jul 13, 2021 •
edited

Codecov Report

Merging #146 (c0154fc) into master (5bc1357) will increase coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #146      +/-   ##
==========================================
+ Coverage   79.77%   79.88%   +0.11%     
==========================================
  Files          10       10              
  Lines         529      532       +3     
  Branches      121      122       +1     
==========================================
+ Hits          422      425       +3     
  Misses         74       74              
  Partials       33       33
Impacted Files Coverage Δ
src/env.ts 97.14% <100.00%> (+0.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bc1357...c0154fc. Read the comment docs.

@agocs
Copy link
Contributor

agocs commented Jul 14, 2021

Looks great so far. I think all that's missing is documenting enableDDLogs in the README.md. That change should automatically be reflected in the docs page.

@astuyve astuyve requested a review from agocs July 14, 2021 20:10
agocs
agocs approved these changes Jul 14, 2021
View reviewed changes
package.json
"check-formatting": "prettier --check src/**",
"format": "prettier --write src/**"
"check-formatting": "prettier --check \"src/**\" \"README.md\"",
"format": "prettier --write \"src/**\" \"README.md\""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

nhinsch
nhinsch reviewed Jul 14, 2021
View reviewed changes
README.md Outdated
| `logLevel` | The log level, set to `DEBUG` for extended logging. |
| `enableXrayTracing` | Set `true` to enable X-Ray tracing on the Lambda functions and API Gateway integrations. Defaults to `false`. |
| `enableDDTracing` | Enable Datadog tracing on the Lambda function. Defaults to `true`. |
| `enableDDLogs` | Enable Datadog log collection for the Lambda function. Defaults to `true`. |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this apply when using the Datadog Forwarder?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the answer to my own question is "no", that is, this setting only affects log collection if the customer is using the Lambda Extension, and not the older but still more popular Datadog Forwarder-based approach. I think we should document that here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you're correct, it doesn't apply to the Datadog Forwarder. Good call on documenting that here, will do

@nhinsch nhinsch mentioned this pull request Jul 15, 2021
Merged
10 tasks
@astuyve astuyve requested a review from nhinsch July 15, 2021 17:09
@astuyve astuyve merged commit b111e55 into master Jul 15, 2021
@astuyve astuyve deleted the aj.stuyvenberg/expose_dd_logs_enabled branch July 15, 2021 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agocs agocs agocs approved these changes

@nhinsch nhinsch Awaiting requested review from nhinsch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@astuyve @codecov-commenter @agocs @nhinsch