Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add upload git metadata config parameter to README.md #348

Merged
merged 4 commits into from
Feb 16, 2023

Conversation

thedavl
Copy link
Contributor

@thedavl thedavl commented Feb 9, 2023

What does this PR do?

this prev PR (which has been included in the recent release) added a new uploadGitMetadata config parameter which defaults to true. Update docs to reflect this, and add a note that users should set this config to false if they have the Datadog github integration.

Motivation

Update docs to reflect recent config changes

Testing Guidelines

Additional Notes

Types of changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog

@codecov-commenter
Copy link

codecov-commenter commented Feb 9, 2023

Codecov Report

Merging #348 (fb5abff) into master (0f15029) will not change coverage.
The diff coverage is n/a.

❗ Current head fb5abff differs from pull request most recent head 1fc930b. Consider uploading reports for the commit 1fc930b to get more accurate results

@@           Coverage Diff           @@
##           master     #348   +/-   ##
=======================================
  Coverage   75.15%   75.15%           
=======================================
  Files          11       11           
  Lines         789      789           
  Branches      238      238           
=======================================
  Hits          593      593           
  Misses        147      147           
  Partials       49       49           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@thedavl thedavl changed the title Update README.md Add git metadata upload config parameter to README.md Feb 9, 2023
@thedavl thedavl changed the title Add git metadata upload config parameter to README.md Add upload git metadata config parameter to README.md Feb 9, 2023
@thedavl thedavl marked this pull request as ready for review February 16, 2023 00:39
@thedavl thedavl requested review from a team as code owners February 16, 2023 00:39
@thedavl thedavl merged commit 57d5a20 into master Feb 16, 2023
@thedavl thedavl deleted the david.lee/docs-source-code-integration branch February 16, 2023 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants