Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for Node 20 #449

Merged
merged 4 commits into from
Nov 21, 2023

Conversation

duncanista
Copy link
Contributor

What does this PR do?

Adds support for Node 20 as it's available for AWS Lambda.

Motivation

It's widely available, and the latest layer (v100) has already been released with support for it.

Also #448

Testing Guidelines

  • Unit tests
  • Integration tests

Additional Notes

Types of changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog

@duncanista duncanista requested a review from a team as a code owner November 21, 2023 16:06
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (543c369) 75.97% compared to head (84a7117) 75.97%.

❗ Current head 84a7117 differs from pull request most recent head d989f1e. Consider uploading reports for the commit d989f1e to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #449   +/-   ##
=======================================
  Coverage   75.97%   75.97%           
=======================================
  Files          13       13           
  Lines         945      945           
  Branches      297      297           
=======================================
  Hits          718      718           
  Misses        166      166           
  Partials       61       61           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@duncanista duncanista mentioned this pull request Nov 21, 2023
10 tasks
@duncanista duncanista merged commit fdee48d into main Nov 21, 2023
9 checks passed
@duncanista duncanista deleted the jordan.gonzalez/SVLS-4188/add-node-20-support branch November 21, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants