Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Deprecate Node.js 14.x instrumentation #467

Merged
merged 16 commits into from Feb 14, 2024

Conversation

duncanista
Copy link
Contributor

What does this PR do?

Deprecates Node.js 14.x instrumentation.

Motivation

Node.js 14.x went in deprecation phase 2 as per AWS Lambda Runtime Deprecation Policy.

Testing Guidelines

n/a

Additional Notes

Types of changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog

@duncanista duncanista requested a review from a team as a code owner February 9, 2024 22:26
@duncanista duncanista changed the base branch from main to jordan.gonzalez/deprecate-node12.x February 9, 2024 22:26
@codecov-commenter
Copy link

codecov-commenter commented Feb 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6cd74e6) 76.33% compared to head (4626186) 76.33%.

❗ Current head 4626186 differs from pull request most recent head 53cd73e. Consider uploading reports for the commit 53cd73e to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #467   +/-   ##
=======================================
  Coverage   76.33%   76.33%           
=======================================
  Files          12       12           
  Lines         955      955           
  Branches      299      299           
=======================================
  Hits          729      729           
  Misses        164      164           
  Partials       62       62           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from jordan.gonzalez/deprecate-node12.x to main February 14, 2024 19:34
@duncanista duncanista merged commit 8c59371 into main Feb 14, 2024
9 checks passed
@duncanista duncanista deleted the jordan.gonzalez/deprecate-node14.x branch February 14, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants