Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove requirement for default VPC and default subnets from aws.exfiltration.rds-share-snapshot. Add output indicating if an attack technique is slow. #284

Merged
merged 3 commits into from
Dec 7, 2022

Conversation

briandefiant
Copy link
Contributor

What does this PR do?

  • Bug fix
  • Enhancement

Motivation

Checklist

Behavior when detonating aws.exfiltration.rds-share-snapshot prior to this change (with no default VPC or default subnets configured):

2022/12/06 12:46:58 Checking your authentication against AWS
2022/12/06 12:46:59 Warming up aws.exfiltration.rds-share-snapshot
2022/12/06 12:46:59 Applying Terraform to spin up technique prerequisites
2022/12/06 12:47:03 unable to run terraform apply on prerequisite: unable to apply Terraform: exit status 1

Error: Error creating DB Instance: InvalidSubnet: No default subnet detected in VPC. Please contact AWS Support to recreate default Subnets.
        status code: 400, request id: ______

  with aws_db_instance.default,
  on main.tf line 31, in resource "aws_db_instance" "default":
  31: resource "aws_db_instance" "default" {

Behavior after (including note about slow attack technique):

2022/12/06 13:33:57 Checking your authentication against AWS
2022/12/06 13:33:58 Note: This is a slow attack technique, it might take a long time to detonate
2022/12/06 13:33:58 Warming up aws.exfiltration.rds-share-snapshot
2022/12/06 13:33:58 Applying Terraform to spin up technique prerequisites
2022/12/06 13:41:44 RDS Snapshot exfiltration of RDS Instance terraform-______ is ready
2022/12/06 13:41:44 Sharing RDS Snapshot exfiltration with an external AWS account

…tration.rds-share-snapshot. Add output indicating if an attack technique is slow.
@christophetd
Copy link
Contributor

Thanks a lot! This looks great. I'll quickly test it locally and merge it afterwards. Appreciate the contribution!

@christophetd christophetd merged commit f193d0a into DataDog:main Dec 7, 2022
@briandefiant briandefiant deleted the briandefiant branch December 7, 2022 14:30
@briandefiant briandefiant restored the briandefiant branch December 7, 2022 14:31
@briandefiant briandefiant deleted the briandefiant branch December 7, 2022 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants