Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add STRATUS_RED_TEAM_ATTACKER_EMAIL env to gcp.exfiltration.share-compute-disk #386

Merged

Conversation

pberba
Copy link
Contributor

@pberba pberba commented Jul 17, 2023

What does this PR do?

This adds the STRATUS_RED_TEAM_ATTACKER_EMAIL env variable to change the attacker email that is used in the IAM policy for gcp.exfiltration.share-compute-disk

Motivation

This addresses #385 and allows user of the technique to use their own external user.

@christophetd
Copy link
Contributor

This is a great idea, thanks for the contribution! What do you think of trying to factor out this piece of code (perhaps under "utils/gcp.go") to avoid copy-pasting it around attack techniques? Happy to help if needed

Copy link
Contributor

@christophetd christophetd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great, thanks for the contribution!

@christophetd christophetd merged commit bb96865 into DataDog:main Jul 27, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants