apps/golang: fix flush and enable span sampling tests #576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enable single span sampling tests for the Go Tracer after fixes in DataDog/dd-trace-go#1509. Some bugs in the test setup needed to be fixed in order to accomplish this: - The Flush APIs needed to call Flush instead of Stop - One of the tests was flaky at 1 second. Moving it to 2 appears to deflake this. This PR updates the go.mod to point to DataDog/dd-trace-go#1509, which is currently under review.
Kyle-Verhoog
approved these changes
Oct 17, 2022
ZStriker19
approved these changes
Oct 17, 2022
Kyle-Verhoog
requested changes
Oct 25, 2022
cbeauchesne
approved these changes
Oct 26, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enable single span sampling tests for the Go Tracer after fixes in DataDog/dd-trace-go#1509.
Some bugs in the test setup needed to be fixed in order to accomplish this:
This PR updates the go.mod to point to DataDog/dd-trace-go#1509, which is now merged.
Check list
Your PR is not ready to be reviewed? Please save it as a draft 馃檹
Yes to all? Feel free to merge it whenever you want 鉂わ笍