Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APPSEC_RUNTIME_ACTIVATION scenario #628

Merged
merged 4 commits into from
Nov 14, 2022
Merged

Conversation

cataphract
Copy link
Contributor

@cataphract cataphract commented Nov 4, 2022

Description

Add scenario where appsec is in the default inactive state and is enabled through remote config.

Check list

  • Follows the style guidelines of this project (See how to easily lint the code)
  • CI is passing
  • There is at least one approval from code owners

@cataphract cataphract requested a review from a team as a code owner November 4, 2022 12:22
@Julio-Guerra
Copy link

Very nice 👏 Let's put it in the feature matrix once merged, in place of the current test we've put in the 1-click enable 🙏
And please let the team know about this new test and scenario.

@Julio-Guerra
Copy link

This test should pass for nodejs (still on the feature branch) and go (merged in the main branch)
cc @simon-id @Hellzy

@simon-id
Copy link
Member

simon-id commented Nov 9, 2022

Also who the hell formats JSON with spaces before colons, the other json files don't have that

Co-authored-by: simon-id <simon.id@datadoghq.com>
@smola
Copy link
Member

smola commented Nov 11, 2022

@simon-id I applied your proposed changes, but I still see it failing in Node: https://github.com/DataDog/system-tests/actions/runs/3437494730/jobs/5732343418

@simon-id
Copy link
Member

@smola as Julio wrote in the message just above:

This test should pass for nodejs (still on the feature branch)

It's not expected to pass on master, hence I didn't enable the test.

@cataphract cataphract merged commit 3410e04 into main Nov 14, 2022
@cataphract cataphract deleted the glopes/appsec_runtime_activ branch November 14, 2022 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants