Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add available_values property to dashboard template variables #1195

Merged
merged 4 commits into from
Sep 15, 2021

Conversation

adil-alimbetov
Copy link
Contributor

This PR adds the available_values property to template variables.
Related PRs:

@adil-alimbetov adil-alimbetov requested review from a team as code owners September 10, 2021 13:05
@adil-alimbetov
Copy link
Contributor Author

Not sure if I should remove available_values from examples for test to pass 🤔

Copy link

@apigirl apigirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one small docs feedback, otherwise lgtm

@@ -11013,6 +11013,7 @@ Required:

Optional:

- **available_values** (List of String) The list of values that the template variable drop-down is be limited to
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- **available_values** (List of String) The list of values that the template variable drop-down is be limited to
- **available_values** (List of strings) The list of values that the template variable drop-down is be limited to.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm afraid this one was autogenerated and beyond my control 😅

@therve
Copy link
Contributor

therve commented Sep 15, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@therve therve changed the title [template variables] Add available_values property to template variables Add available_values property to dashboard template variables Sep 15, 2021
@therve therve enabled auto-merge (squash) September 15, 2021 11:58
@therve therve merged commit 5a5507d into master Sep 15, 2021
@therve therve deleted the adil/template-variables-available-values branch September 15, 2021 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants