Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[provider] Fix segfault on invalid API URL #1921

Merged
merged 2 commits into from
May 17, 2023
Merged

[provider] Fix segfault on invalid API URL #1921

merged 2 commits into from
May 17, 2023

Conversation

nkzou
Copy link
Contributor

@nkzou nkzou commented May 17, 2023 •
edited

parseErr is always nil if the edited code block is entered, so we cannot call Error() on it.

Fixes segfaults when the API url is missing protocol or host, such as api.datadoghq.com instead of https://api.datadoghq.com

@nkzou nkzou requested a review from a team as a code owner May 17, 2023 19:15
@nkzou nkzou merged commit e4b8dda into master May 17, 2023
8 checks passed
@nkzou nkzou deleted the kevinzou/api_url_segfault branch May 17, 2023 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skarimo skarimo skarimo approved these changes

Assignees
No one assigned
Labels
changelog/bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nkzou @skarimo