[datadog_provider] Add resource wrapper and support adding enum values to docs #1922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkzou
reviewed
May 19, 2023
| } | ||
| description = fmt.Sprintf("%s Valid values are %s.", description, validValuesMsg) | ||
| break | ||
| } |
There was a problem hiding this comment.
Suggested change
| } | |
| } | |
| if validators.Index(i).Elem().Type().Name() == "atLeastValidator" { | |
| atLeast := validators.Index(i).Elem().FieldByName("min") | |
| if atLeast.IsValid() { | |
| description = fmt.Sprintf("%s Value must be at least %d.", description, atLeast.Int()) | |
| break | |
| } | |
| } |
thoughts on adding more validators to this?
There was a problem hiding this comment.
Good idea, I will work on this in a separate pr. I would need to cross check what type of validation are included in the documentation for resources written using terraform-plugin-sdk and implement the same ones for framework.
skarimo
changed the title
nkzou
previously approved these changes
May 22, 2023
Co-authored-by: Kevin Zou <17015060+nkzou@users.noreply.github.com>
nkzou
approved these changes
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.